Skip to content

Adding github actions to automate releases#68

Open
nkitsaini wants to merge 6 commits into
Amegma:masterfrom
nkitsaini:master
Open

Adding github actions to automate releases#68
nkitsaini wants to merge 6 commits into
Amegma:masterfrom
nkitsaini:master

Conversation

@nkitsaini

@nkitsaini nkitsaini commented Oct 23, 2022

Copy link
Copy Markdown
Contributor

The action will trigger whenever a stable or pre-release release is published. It'll build the EXE for that specific release and add it to the release artifacts.

The action will not run when draft is created. It's a limitation from github right now:
https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#release

ankitlabs and others added 2 commits October 23, 2022 14:45
* New release will be created whenever a git tag similar to `v*` pattern
  is pushed
* Release body will contain the tag message and a link to full changelog
  since last release
@Mayank0255

Copy link
Copy Markdown
Member

@nkitsaini I think the trigger can be something else, so that it eliminates the manual effort of pushing the release.

My automating releases I dont mean that the release itself gets triggered on its own, I mean that whenever I make a release, it builds the updated exe file and embeds it into the release itself

@nkitsaini

Copy link
Copy Markdown
Contributor Author

@Mayank0255 I see. let me make the changes.

@nkitsaini

Copy link
Copy Markdown
Contributor Author

@Mayank0255 I've made the changes. See Pull request description detail.

@Mayank0255

Copy link
Copy Markdown
Member

@nkitsaini have you tested if its working or not?

@nkitsaini

Copy link
Copy Markdown
Contributor Author

@Mayank0255 Yes, it is working. I've invited you to my fork. You can create manual releases and the .exe file will be attached to release artifacts once the github action is executed.

@Mayank0255

Copy link
Copy Markdown
Member

@Mayank0255 Yes, it is working. I've invited you to my fork. You can create manual releases and the .exe file will be attached to release artifacts once the github action is executed.

Ya, I saw that, but the game is crashing on launch itself, pls check that
image

@nkitsaini

nkitsaini commented Dec 11, 2022

Copy link
Copy Markdown
Contributor Author

@Mayank0255 Interesting, Which version of python are you using?

@Mayank0255

Copy link
Copy Markdown
Member

@nkitsaini
I am using 3.10.1

@nkitsaini

nkitsaini commented Dec 11, 2022

Copy link
Copy Markdown
Contributor Author

@Mayank0255 Can you try the newer build from here: https://github.com/nkitsaini/Galaxy-Attack/releases/tag/manual-11 ? I do not have windows available at the moment. If this does not work, I'll take a look later this week.

@Mayank0255

Copy link
Copy Markdown
Member

@Mayank0255 Can you try the newer build from here: https://github.com/nkitsaini/Galaxy-Attack/releases/tag/manual-11 ? I do not have windows available at the moment. If this does not work, I'll take a look later this week.

Getting a different error

Traceback (most recent call last):
  File "main.py", line 7, in <module>
ModuleNotFoundError: No module named 'screens.controls'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants